Fix Settings view on iPad #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was appearing in sidebar not detail view in split view
PaulRWillis
changed the title
These were causing navigation issues when used with `NavigationSplitView`
PaulRWillis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where the
Settingsview on iPad was appearing in sidebar not detail view in split view.@adamrushy This was the iPad navigation bug raised earlier in Slack.
This PR also removes any use of the deprecated
NavigationViewin the app, replacing it withNavigationStack.Screenshots
Screenshot of bug before fix
Screenshot after fix