-
-
Notifications
You must be signed in to change notification settings - Fork 10
Import SwiftGen package #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `SharedAssets` module
Stencil needs further work to handle all Assets.xcassets within a designated input folder
App icons left in place
…source and SLImageResource
adamrushy
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing package to being modularizing iOS assets such as images and colors.
Changes
SharedAssetsmodule and package.SharedAssets.Backwards compatibility
Copies of all colors and images have been left in the project-level asset catalogs for now.
This is needed to support code that hasn't yet been modularized. These assets will eventually be removed.
App icons
Separately, I noticed that the app's "app icons" are still in the asset catalog instead of separate images from Icon Composer. We might need to keep an asset catalog of app icons in the main project and out of SPM to support this.
@adamrushy are there plans to use Icon Composer to move away from asset catalog icons?