bugfix(URLSession): Enable URLCache
#59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching now handled internally by `URLSession`. No need to call this function
…ached` Caching now handled internally by `URLSession`. No need to call this function
Caching now handled internally by `URLSession`. No need to call this function
…/enable-url-cache
…x/enable-url-cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Network caching was relying on a manual file manager-based implementation
Solution
Enable
URLCacheinURLSession.sharedglobal singleton to automatically handle network-related cachingAdditional notes
URLSessionimplementation, including removingcached()functionScreenshots
Screenshot: existing issue where loading shows on no internet connection
Screenshot: loaded data from network
Screenshot: loaded data from `URLCache`