Adding Settings Screen + App Icon Switcher #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRWillis
reviewed
Aug 24, 2025
| import SwiftUI | ||
|
|
||
| struct SettingsView: View { | ||
| @EnvironmentObject var themeManager: ThemeManager |
Collaborator
There was a problem hiding this comment.
Nit: Could this be private?
PaulRWillis
reviewed
Aug 24, 2025
| } | ||
|
|
||
| Section("About") { | ||
| HStack { |
Collaborator
There was a problem hiding this comment.
Nit: I think this could work well with LabeledContent since we support iOS 16
Or alternatively a .badge modifier: badge(_:)
PaulRWillis
reviewed
Aug 24, 2025
Collaborator
PaulRWillis
left a comment
PaulRWillis
left a comment
There was a problem hiding this comment.
Great to have new app icons ready for the space theme this year! 💃
kmuralidharan91
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic settings screen along with theme switching + App Icon switching.
The red text on default button is a little misleading here because they look "destructive" but think it's fine for now.