Update Sponsor Screen #56
Conversation
…te-sponsor-screen
There was a problem hiding this comment.
Pull Request Overview
This PR significantly updates the Sponsors screen with improved UI design and filtering functionality. The main changes include adding visual filtering chips, enhanced loading states, and improved sponsor tile designs.
- Replaces the basic list view with a modern ScrollView layout featuring loading states and empty states
- Adds sponsor filtering by tier (Platinum, Gold, Silver) with animated filter chips
- Enhances sponsor tiles with better visual hierarchy, job indicators, and collapsible job sections
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| SponsorsView.swift | Complete redesign with filtering functionality, loading states, and improved layout |
| SponsorTileView.swift | Enhanced tile design with job section expansion, better accessibility, and visual improvements |
| ShimmerView.swift | New component for loading state animations |
| project.pbxproj | Project file updates to include the new ShimmerView component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| loadingView | ||
| .padding(.top, Padding.screen) |
There was a problem hiding this comment.
The loading state check should account for potential loading errors. Currently, if viewModel.loadSponsors() throws an error, isLoading is set to false but viewModel.sections might still be empty, causing the empty state to show instead of an error state.
| loadingView | |
| .padding(.top, Padding.screen) | |
| .padding(.top, Padding.screen) | |
| } else if let error = error { | |
| errorView(error: error) | |
| .padding(.top, Padding.screen) |
There was a problem hiding this comment.
Hmm, but am not sure if we have any decent errors from the API to present so I think showing an empty list is probably fine here 👍🏼
| if let url = URL(string: sponsor.url) { | ||
| openURL(url) |
There was a problem hiding this comment.
The URL validation check is redundant here since sponsor.url is already a String and openURL environment value expects a URL. The original code directly passed the URL string to a helper function. This could fail silently if sponsor.url is not a valid URL format.
| if let url = URL(string: sponsor.url) { | |
| openURL(url) | |
| if let url = URL(string: sponsor.url), UIApplication.shared.canOpenURL(url) { | |
| openURL(url) | |
| } else { | |
| showingInvalidURLAlert = true |
| @State private var isPressed = false | ||
|
|
||
| var body: some View { | ||
| Button(action: { | ||
| if let url = URL(string: job.url) { | ||
| openURL(url) |
There was a problem hiding this comment.
Same URL validation issue as in the main tile. The code should handle invalid URLs more gracefully, potentially showing an error message or logging the failure instead of silently doing nothing.
| @State private var isPressed = false | |
| var body: some View { | |
| Button(action: { | |
| if let url = URL(string: job.url) { | |
| openURL(url) | |
| @State private var isPressed = false | |
| @State private var showInvalidUrlAlert = false | |
| var body: some View { | |
| Button(action: { | |
| if let url = URL(string: job.url) { | |
| openURL(url) | |
| } else { | |
| showInvalidUrlAlert = true |
It's mainly a UI update this one, it includes a way to filter the sponsors as well jus a bit more easier to navigate.