Skip to content

Add support for Bugsnag version 6 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zhong-z wants to merge 6 commits into from
Closed

Add support for Bugsnag version 6 #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17aac59
Add support for Bugsnag version 6
Zhong-z Mar 10, 2018
f4be7c7
:white_check_mark: Update spec to use Bugsnag class method
Zhong-z Mar 11, 2018
d3868f9
:art: explicitly use old rspec gem
Zhong-z Mar 11, 2018
0bb2fd0
update rspec version
Zhong-z Mar 11, 2018
1cd446c
Revert "update rspec version"
Zhong-z Mar 11, 2018
82d76fa
Revert ":art: explicitly use old rspec gem"
Zhong-z Mar 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/rocket_pants/controller/rescuable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ module Rescuable
end
},
:bugsnag => lambda { |controller, exception, request|
controller.send(:notify_bugsnag, exception, request: request)
if controller.respond_to?(:notify_bugsnag, true)
controller.send(:notify_bugsnag, exception, request: request)
else
# Bugsnag v6 removed #notify_bugsnag controller method
# Use #notify directly
Bugsnag.notify(exception)
end
}
}

Expand Down
3 changes: 3 additions & 0 deletions spec/rocket_pants/controller/error_handling_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@
before :each do
controller_class.use_named_exception_notifier :bugsnag
stub.instance_of(controller_class).notify_bugsnag {}
Bugsnag = Class.new do
define_singleton_method(:notify) { |exception| }
end
end

it 'should send notification when it is the named exception notifier' do
Expand Down