-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/ef/treeview tables #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namic archive. Shows result in the new treeview. part1
…namic archive. Shows result in the new treeview. part2
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Extra Tables Explorer functionality to the VS Code extension, including new tree view provider, HTTP service methods, and improved error handling in the HTTP handler.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/superofficedx-vscode-core/src/types/odata/odataResponse.ts | New file defining shared OData metadata interface |
| packages/superofficedx-vscode-core/src/types/odata/extratable.ts | New file defining ExtraTable types |
| packages/superofficedx-vscode-core/src/types/odata/script.ts | Refactored to import shared OData metadata interface |
| packages/superofficedx-vscode-core/src/services/httpService.ts | Added getExtraTables method and endpoint |
| packages/superofficedx-vscode-core/src/providers/extraTablesTreeViewDataProvider.ts | New tree view provider for extra tables |
| packages/superofficedx-vscode-core/src/handlers/httpHandler.ts | Enhanced error handling with HttpError class, timeout support, and improved request options |
| packages/superofficedx-vscode-core/src/extension.ts | Registered new extra tables tree view provider |
| packages/superofficedx-vscode-core/src/container/configurations/providerConfiguration.ts | Added DI registration for extra tables provider |
| packages/superofficedx-vscode-core/src/container/configurations/configurationKeys.ts | Added configuration key for extra tables provider |
| packages/superofficedx-vscode-core/package.json | Added Extra Tables Explorer view to package manifest |
| packages/superofficedx-vscode-core/src/utils.ts | Updated import path for ScriptEntity |
| packages/superofficedx-vscode-core/src/services/fileSystemService.ts | Updated import path for ScriptEntity |
| packages/superofficedx-vscode-core/src/providers/treeViewDataProvider.ts | Updated import path for ScriptInfo |
| packages/superofficedx-vscode-core/src/commands/types/commandContracts.ts | Updated import path for ScriptInfo |
| packages/superofficedx-vscode-core/src/commands/handlers/scriptCommands.ts | Updated import path for ScriptInfo |
| packages/superofficedx-vscode-core/tests/unit/vitest/handlers/httpHandler.test.ts | Updated test to match new error message format |
| packages/superofficedx-vscode-core/tests/suite/commands/registerCommands.test.ts | New test file for command registration |
packages/superofficedx-vscode-core/src/providers/extraTablesTreeViewDataProvider.ts
Show resolved
Hide resolved
packages/superofficedx-vscode-core/tests/suite/commands/registerCommands.test.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/providers/extraTablesTreeViewDataProvider.ts
Outdated
Show resolved
Hide resolved
…erCommands.test.ts Co-authored-by: Copilot <[email protected]>
…eeViewDataProvider.ts Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a treeview of extraTables and fields, with some additional fieldinfo, to the extension view:
