-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/ef/add playwright #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Playwright for end-to-end testing of the VS Code extension, restructures the test directory, and refactors the authentication service to support testability. The changes enable automated UI testing of the extension's OAuth flow and command execution.
- Adds Playwright test framework with E2E tests for OAuth flow and extension commands
- Restructures test organization (unit tests under
tests/unit/vitest/, E2E undertests/e2e/playwright/) - Refactors
AuthenticationServiceto extractgenerateAuthorizeUrlfor better testability
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.config.ts |
Updates project reference and adds esbuild target configuration |
test-results/.last-run.json |
Adds test results file (should be gitignored) |
packages/superofficedx-vscode-core/vitest.config.ts |
Updates test paths and coverage configuration with incorrect include pattern |
packages/superofficedx-vscode-core/vitest-setup.ts |
Adds VS Code API mocking setup for Vitest tests |
packages/superofficedx-vscode-core/tests/unit/vitest/**/*.test.ts |
Updates import paths to match new directory structure |
packages/superofficedx-vscode-core/tests/e2e/playwright/workbox.ts |
Adds Playwright fixture for launching VS Code with extension |
packages/superofficedx-vscode-core/tests/e2e/playwright/oauth-flow.spec.ts |
Adds E2E tests for OAuth sign-in flow |
packages/superofficedx-vscode-core/tests/e2e/playwright/basic.spec.ts |
Adds basic E2E smoke tests for extension loading |
packages/superofficedx-vscode-core/src/services/authenticationService.ts |
Refactors login logic by extracting URL generation into testable method |
packages/superofficedx-vscode-core/playwright.config.ts |
Configures Playwright for VS Code extension testing |
packages/superofficedx-vscode-core/package.json |
Removes ESM mode, pins dependency versions including invalid esbuild version |
package.json |
Updates root dependencies with invalid esbuild version |
.github/general-coding.instructions.md |
Adds general coding standards documentation |
.github/copilot-instructions.md |
Updates with TypeScript guidelines and reorganized structure |
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
packages/superofficedx-vscode-core/src/services/authenticationService.ts
Outdated
Show resolved
Hide resolved
…Service.ts Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…Service.ts Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…Service.ts Co-authored-by: Copilot <[email protected]>
No description provided.