Skip to content

Conversation

@ejfasting
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Playwright for end-to-end testing of the VS Code extension, restructures the test directory, and refactors the authentication service to support testability. The changes enable automated UI testing of the extension's OAuth flow and command execution.

  • Adds Playwright test framework with E2E tests for OAuth flow and extension commands
  • Restructures test organization (unit tests under tests/unit/vitest/, E2E under tests/e2e/playwright/)
  • Refactors AuthenticationService to extract generateAuthorizeUrl for better testability

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
vitest.config.ts Updates project reference and adds esbuild target configuration
test-results/.last-run.json Adds test results file (should be gitignored)
packages/superofficedx-vscode-core/vitest.config.ts Updates test paths and coverage configuration with incorrect include pattern
packages/superofficedx-vscode-core/vitest-setup.ts Adds VS Code API mocking setup for Vitest tests
packages/superofficedx-vscode-core/tests/unit/vitest/**/*.test.ts Updates import paths to match new directory structure
packages/superofficedx-vscode-core/tests/e2e/playwright/workbox.ts Adds Playwright fixture for launching VS Code with extension
packages/superofficedx-vscode-core/tests/e2e/playwright/oauth-flow.spec.ts Adds E2E tests for OAuth sign-in flow
packages/superofficedx-vscode-core/tests/e2e/playwright/basic.spec.ts Adds basic E2E smoke tests for extension loading
packages/superofficedx-vscode-core/src/services/authenticationService.ts Refactors login logic by extracting URL generation into testable method
packages/superofficedx-vscode-core/playwright.config.ts Configures Playwright for VS Code extension testing
packages/superofficedx-vscode-core/package.json Removes ESM mode, pins dependency versions including invalid esbuild version
package.json Updates root dependencies with invalid esbuild version
.github/general-coding.instructions.md Adds general coding standards documentation
.github/copilot-instructions.md Updates with TypeScript guidelines and reorganized structure

@ejfasting ejfasting merged commit 4dab24a into main Nov 18, 2025
2 checks passed
@ejfasting ejfasting deleted the Feature/EF/add_playwright branch November 18, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants