Address unresolved review comments from PR #170 - #172
Merged
Conversation
…tandardize rules Co-authored-by: lebull <3135984+lebull@users.noreply.github.com>
Co-authored-by: lebull <3135984+lebull@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add host poster management feature for events
Address unresolved review comments from PR #170
Jan 4, 2026
|
Visit the preview URL for this PR (updated for commit 0827576): https://sunday-service-vr--pr172-copilot-sub-pr-170-vw5vzktu.web.app (expires Sun, 11 Jan 2026 17:42:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 58385af7bd5a89154351e3a6f5764ea3ef89db5c |
lebull
marked this pull request as ready for review
January 4, 2026 17:46
lebull
added a commit
that referenced
this pull request
Jan 4, 2026
* Implement host poster feature * Fix lint * Make rules cleaner. * Reconcile the host data into the event. * Update webapp/src/hooks/useEventStore/eventReconciliation.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update webapp/src/features/clubSettings/HostList.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update webapp/src/store/clubSettings.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update webapp/src/features/clubSettings/DefaultPosterSettings.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Address unresolved review comments from PR #170 (#172) * Initial plan * Address review comments: fix JSDoc, typo, add Firestore update, and standardize rules Co-authored-by: lebull <3135984+lebull@users.noreply.github.com> * Fix syntax error in clubSettings.ts - add missing closing brace Co-authored-by: lebull <3135984+lebull@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lebull <3135984+lebull@users.noreply.github.com> * Adjust label wording --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: lebull <3135984+lebull@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes unresolved code quality issues from the host poster feature review, including incomplete documentation, typos, missing persistence logic, and inconsistent security rule syntax.
Changes
docToHostwith param/return descriptionsgetReconcicledEvent→getReconciledEventhasAny(['admin', 'host'])syntax matching storage.rules💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.