-
Notifications
You must be signed in to change notification settings - Fork 1
Implement host poster feature #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
de8e03f
Implement host poster feature
lebull b48ec0a
Fix lint
lebull ae0c42f
Merge branch 'main' into host-poster-support
lebull 0279729
Merge branch 'main' into host-poster-support
lebull d4f7e0d
Make rules cleaner.
lebull 0217365
Reconcile the host data into the event.
lebull 5412756
Merge branch 'host-poster-support' of https://github.com/SundayServic…
lebull 077759f
Update webapp/src/hooks/useEventStore/eventReconciliation.ts
lebull 95cd39a
Update webapp/src/features/clubSettings/HostList.tsx
lebull 2b65d7f
Update webapp/src/store/clubSettings.ts
lebull e6b268e
Update webapp/src/features/clubSettings/DefaultPosterSettings.tsx
lebull 6c520ee
Address unresolved review comments from PR #170 (#172)
Copilot dad45b1
Adjust label wording
lebull 0f0f69a
Merge branch 'host-poster-support' of https://github.com/SundayServic…
lebull File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import { Dj, Event } from "../../util/types"; | ||
| import { Dj, Event, Host } from '../../util/types'; | ||
|
|
||
| export type DjCache = Map<string, Dj>; | ||
| export type HostCache = Map<string, Host>; | ||
| export type EventCache = Map<string, Event>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { useState } from "react"; | ||
| import { Container, Tabs, Tab } from "react-bootstrap"; | ||
| import HostList from "./HostList"; | ||
| import DefaultPosterSettings from "./DefaultPosterSettings"; | ||
|
|
||
| const ClubSettings = () => { | ||
| const [activeTab, setActiveTab] = useState<string>("hosts"); | ||
|
|
||
| return ( | ||
| <Container className="mt-4"> | ||
| <h1 className="display-5 mb-4">Club Settings</h1> | ||
|
|
||
| <Tabs | ||
| activeKey={activeTab} | ||
| onSelect={(k) => setActiveTab(k || "hosts")} | ||
| className="mb-3" | ||
| > | ||
| <Tab eventKey="hosts" title="Hosts"> | ||
| <HostList /> | ||
| </Tab> | ||
| <Tab eventKey="defaultPoster" title="Default Poster"> | ||
| <DefaultPosterSettings /> | ||
| </Tab> | ||
| </Tabs> | ||
| </Container> | ||
| ); | ||
| }; | ||
|
|
||
| export default ClubSettings; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The storage rules use different syntax patterns inconsistently. Line 21 uses the newer hasAny() method with an array literal, while lines 9 and 16 in firestore.rules use the older 'in' operator. Consider standardizing on the hasAny() method for consistency and better readability across both rule files.