Skip to content

Issue #SBCOSS-00: Remove fields from activityConfig.json to remove bgms hardcoding#202

Merged
pallakartheekreddy merged 1 commit intorelease-8.0.0from
bgms-hard-coding
Sep 24, 2025
Merged

Issue #SBCOSS-00: Remove fields from activityConfig.json to remove bgms hardcoding#202
pallakartheekreddy merged 1 commit intorelease-8.0.0from
bgms-hard-coding

Conversation

@chethann007
Copy link
Copy Markdown
Contributor

@chethann007 chethann007 commented Sep 23, 2025

Summary

This PR removes the restriction of returning only specific fields from the service when reading activity data.
The hardcoded bgms fields have also been removed to make the configuration more flexible.

Changes

  • Updated logic to return all keys and values from the search-service instead of specific fields.
  • Removed bgms hardcoding from activityConfig.json.

Description by Korbit AI

What change is being made?

Remove the hardcoded field definitions from activityConfig.json by setting "fields" to an empty array for the activities configuration.

Why are these changes being made?

To stop hardcoding fields (bgms related) and allow dynamic/default field handling as part of Issue SBCOSS-00.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

- These fields were removed to return all the keys and values that will be read from the `search-service`
Copy link
Copy Markdown

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this kitten.

    |\__/,|   (`\
  _.|o o  |_   ) )
-(((---(((--------

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
13.8% Coverage on New Code (required ≥ 80%)
3.7% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes hardcoded field definitions from the activity configuration to enable more flexible data retrieval. Instead of restricting the service to return only specific predefined fields, it now allows all available fields to be returned dynamically.

  • Removed hardcoded field restrictions from activity configuration
  • Changed from specific field listing to empty array for dynamic field retrieval
  • Eliminates bgms-related hardcoding for improved configurability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pallakartheekreddy pallakartheekreddy merged commit 86387c8 into release-8.0.0 Sep 24, 2025
2 of 3 checks passed
@pallakartheekreddy pallakartheekreddy deleted the bgms-hard-coding branch September 24, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants