Skip to content

To fix the docker image name which is pushed to GHCR#198

Merged
pallakartheekreddy merged 1 commit intorelease-8.0.0from
docker-image-fix
Jun 23, 2025
Merged

To fix the docker image name which is pushed to GHCR#198
pallakartheekreddy merged 1 commit intorelease-8.0.0from
docker-image-fix

Conversation

@chethann007
Copy link
Copy Markdown
Contributor

@chethann007 chethann007 commented Jun 23, 2025

This PR fixes the docker image tag name where the commit SHA was not being added previously.

Description by Korbit AI

What change is being made?

Update the Docker image tagging process in the GitHub Actions workflow to include a short SHA and the GitHub run number in the IMAGE_TAG.

Why are these changes being made?

These changes ensure that each Docker image pushed to the GitHub Container Registry (GHCR) has a unique tag which includes a short commit SHA and the workflow run number, preventing collisions and aiding in precise version identification and traceability. This approach addresses potential issues with identically named tags across different runs or branches.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link
Copy Markdown

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this bunny.

(\(\
( -.-)
o_(")(")

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GitHub Actions workflow to tag Docker images with a short commit SHA and run number for unique identification.

  • Introduces a SHORT_SHA variable and integrates it into the image tag.
  • Updates IMAGE_TAG to include branch name, short SHA, and run number.
Comments suppressed due to low confidence (2)

.github/workflows/build.yml:84

  • You can use the built-in GITHUB_SHA environment variable with substring expansion instead of invoking git, e.g.: SHORT_SHA=${GITHUB_SHA::7} to simplify the workflow.
          SHORT_SHA=$(git rev-parse HEAD | cut -c1-7)

.github/workflows/build.yml:87

  • Quote your expansions to avoid word-splitting or globbing, e.g.: IMAGE_TAG="${TAG_LOWER}_${SHORT_SHA}_${GITHUB_RUN_NUMBER}".
          IMAGE_TAG=${TAG_LOWER}_${SHORT_SHA}_${GITHUB_RUN_NUMBER}

@pallakartheekreddy pallakartheekreddy merged commit 0d054b5 into release-8.0.0 Jun 23, 2025
2 checks passed
@pallakartheekreddy pallakartheekreddy deleted the docker-image-fix branch June 23, 2025 11:10
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
13.8% Coverage on New Code (required ≥ 80%)
3.7% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants