To fix the docker image name which is pushed to GHCR#198
Merged
pallakartheekreddy merged 1 commit intorelease-8.0.0from Jun 23, 2025
Merged
To fix the docker image name which is pushed to GHCR#198pallakartheekreddy merged 1 commit intorelease-8.0.0from
pallakartheekreddy merged 1 commit intorelease-8.0.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GitHub Actions workflow to tag Docker images with a short commit SHA and run number for unique identification.
- Introduces a
SHORT_SHAvariable and integrates it into the image tag. - Updates
IMAGE_TAGto include branch name, short SHA, and run number.
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:84
- You can use the built-in GITHUB_SHA environment variable with substring expansion instead of invoking git, e.g.:
SHORT_SHA=${GITHUB_SHA::7}to simplify the workflow.
SHORT_SHA=$(git rev-parse HEAD | cut -c1-7)
.github/workflows/build.yml:87
- Quote your expansions to avoid word-splitting or globbing, e.g.:
IMAGE_TAG="${TAG_LOWER}_${SHORT_SHA}_${GITHUB_RUN_NUMBER}".
IMAGE_TAG=${TAG_LOWER}_${SHORT_SHA}_${GITHUB_RUN_NUMBER}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR fixes the docker image tag name where the commit SHA was not being added previously.
Description by Korbit AI
What change is being made?
Update the Docker image tagging process in the GitHub Actions workflow to include a short SHA and the GitHub run number in the IMAGE_TAG.
Why are these changes being made?
These changes ensure that each Docker image pushed to the GitHub Container Registry (GHCR) has a unique tag which includes a short commit SHA and the workflow run number, preventing collisions and aiding in precise version identification and traceability. This approach addresses potential issues with identically named tags across different runs or branches.