TaskId #0000 task:implemted popup message for demo version for milestone level 5 by vishnuvinay09 · Pull Request #163 · Sunbird-ALL/all-learner-ai-app

vishnuvinay09 · 2024-09-13T03:55:36Z

…one level 5

Summary by CodeRabbit

New Features
- Introduced a message dialog that activates when users reach the final milestone, providing contextual feedback.
- Added a new popup notification message to enhance user experience with a call-to-action for support.
- Improved consistency in string formatting for constants used in the application.

…one level 5

coderabbitai · 2024-09-13T03:55:46Z

Walkthrough

The changes involve modifications to the src/config/config.js file, where string constants are reformatted to use double quotes, and new constants for popup text and milestone levels are introduced. Additionally, the Practice component in src/views/Practice/Practice.jsx is updated to include conditional logic that triggers a message dialog when the previous_level matches the maximum milestone level, providing user feedback regarding their progress.

Changes

File	Change Summary
src/config/config.js	Reformatted string constants to double quotes and added `POPUP_TEXT_CONSTANT` and `MILESTONE_LEVEL`.
src/views/Practice/Practice.jsx	Added conditional logic to display a message dialog when `previous_level` is at the maximum milestone level.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PracticeComponent
    participant MessageDialog

    User->>PracticeComponent: Check previous_level
    PracticeComponent->>PracticeComponent: Evaluate getSetData.data.previous_level
    alt previous_level matches max milestone
        PracticeComponent->>MessageDialog: Open dialog with milestone message
    end

Tip

OpenAI O1 model for chat

We have deployed OpenAI's latest O1 model for chat.
OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
Please share any feedback with us in the discussions post.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e1affd and e994c97.

Files selected for processing (2)

src/config/config.js (1 hunks)
src/views/Practice/Practice.jsx (2 hunks)

Files skipped from review as they are similar to previous changes (2)

src/config/config.js
src/views/Practice/Practice.jsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gouravmore · 2024-09-13T06:24:21Z

src/views/Practice/Practice.jsx

            );
          }
          setLocalData("previous_level", getSetData.data.previous_level);
+          if (getSetData.data.previous_level === "m5") {


why this is hardcoded here? this should come from the config

gouravmore · 2024-09-13T08:04:49Z

src/config/config.js


 export const API_CONSTANTS = {
-    API_URL: 'http://localhost:3001/',
+  API_URL: "http://localhost:3001/",


What is this URL for?

from beginning it s the same

gouravmore · 2024-09-13T11:09:22Z

src/config/config.js

+    <>
+      You have reached the final milestone for the demo. To explore additional
+      levels, please{" "}
+      <a href="mailto:sunbird@tekditechnologies.com">click here</a> to contact


this should come from the env configuration

gouravmore · 2024-09-13T11:10:15Z

src/config/config.js

+};
+
+export const MILESTONE_LEVEL = {
+  DEMO_MAX_MILESTONE_LEVEL: "m5",


this should not be hardcoded here. this should be the part of env config

…nv config

gouravmore · 2024-09-13T13:34:49Z

src/views/Practice/Practice.jsx

          }
          setLocalData("previous_level", getSetData.data.previous_level);
+          if (
+            getSetData.data.previous_level ===


Use optional chaining operator

…nv config

sonarqubecloud · 2024-09-13T14:29:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TaskId #0000 task:implemted popup message for demo version for milest…

d0139b5

…one level 5

coderabbitai bot approved these changes Sep 13, 2024

View reviewed changes

sudeeppr1998 approved these changes Sep 13, 2024

View reviewed changes

gouravmore reviewed Sep 13, 2024

View reviewed changes

TaskId #0000 fix:Moved alert message for demo max milestone to config

037a8f9

vishnuvinay09 requested a review from gouravmore September 13, 2024 07:41

gouravmore reviewed Sep 13, 2024

View reviewed changes

vishnuvinay09 added 2 commits September 13, 2024 14:48

TaskID #0000 fix:moved max milestone level to config

76e7f84

TaskID #0000 fix:moved max milestone level to config

9e1affd

gouravmore requested changes Sep 13, 2024

View reviewed changes

TaskID #0000 fix:updated max milestone level and support mail id to e…

e994c97

…nv config

gouravmore requested changes Sep 13, 2024

View reviewed changes

TaskID #0000 fix:updated max milestone level and support mail id to e…

57c7154

…nv config

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TaskId #0000 task:implemted popup message for demo version for milestone level 5#163

TaskId #0000 task:implemted popup message for demo version for milestone level 5#163
vishnuvinay09 wants to merge 6 commits intoSunbird-ALL:all-saas-prodfrom
vishnuvinay09:all-saas-prod

vishnuvinay09 commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

gouravmore Sep 13, 2024

Uh oh!

gouravmore Sep 13, 2024

Uh oh!

vishnuvinay09 Sep 13, 2024

Uh oh!

gouravmore Sep 13, 2024

Uh oh!

gouravmore Sep 13, 2024

Uh oh!

gouravmore Sep 13, 2024

Uh oh!

sonarqubecloud bot commented Sep 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vishnuvinay09 commented Sep 13, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

gouravmore Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

gouravmore Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

vishnuvinay09 Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

gouravmore Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

gouravmore Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

gouravmore Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 13, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vishnuvinay09 commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading