Skip to content

Conversation

@andrzej-stencel
Copy link
Contributor

@andrzej-stencel andrzej-stencel commented Oct 13, 2020

Fixes #995 by upgrading the Fluent plugin that was causing the issue.

Link to the fix in the plugin: fluent-plugins-nursery/fluent-plugin-kubernetes_metadata_filter#204

@pmalek-sumo
Copy link
Contributor

@astencel-sumo Do you mind attaching a link to changelog and/or a release in the description?

@andrzej-stencel
Copy link
Contributor Author

andrzej-stencel commented Oct 13, 2020

@astencel-sumo Do you mind attaching a link to changelog and/or a release in the description?

I'm afraid the plugin does not have a changelog or release descriptions - see the plugin's repo:
https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter

The only thing we have is a list of commits:
https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/compare/22712933a7f42d1839af6d04ff7fd5bf32fadbb6..4119423cb4fd1559ae8c0bf76992c1404b359971

@pmalek-sumo
Copy link
Contributor

@astencel-sumo Do you mind attaching a link to changelog and/or a release in the description?

I'm afraid the plugin does not have a changelog or release descriptions - see the plugin's repo:
https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter

The only thing we have is a list of commits:
https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/compare/22712933a7f42d1839af6d04ff7fd5bf32fadbb6..4119423cb4fd1559ae8c0bf76992c1404b359971

Alright, np. Do we maybe have the PR that fixed our problem?

@andrzej-stencel
Copy link
Contributor Author

Alright, np. Do we maybe have the PR that fixed our problem?

Good point @pmalek-sumo , I've updated the description of the PR with the link to the PR that fixes this issue. Keep in mind there are also other minor fixes in later versions of the plugin, like fluent-plugins-nursery/fluent-plugin-kubernetes_metadata_filter#215, fluent-plugins-nursery/fluent-plugin-kubernetes_metadata_filter#214, and others, see the list of commits between the releases for more details.

Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@andrzej-stencel andrzej-stencel merged commit a5a4041 into master Oct 13, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrzej-stencel andrzej-stencel deleted the bump-kubernetes_metadata_filter-plugin-from-2.4.1-to2.5.2 branch October 13, 2020 15:51
perk-sumo pushed a commit that referenced this pull request Oct 14, 2020
@perk-sumo perk-sumo changed the title Bump fluent-plugin-kubernetes_metadata_filter from 2.4.1 to 2.5.2 Upgrade fluent-plugin-kubernetes_metadata_filter from 2.4.1 to 2.5.2 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fluentd pods are restarted when connection to API server is lost

4 participants