Duplicate filtering by id added #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duchatran
reviewed
Aug 25, 2020
| @@ -24,44 +24,53 @@ function createRecords(config, events, awslogsData) { | |||
| var records = []; | |||
| var lastRequestID = null; | |||
| console.log('Log events: ' + events.length); | |||
|
|
|||
| var msgset = new Set(); | |||
There was a problem hiding this comment.
Do we need to worry about memory size for the function then? How often does this happen?
|
PR not merged reason: We were not able to reproduce it and did not get any confirmation from customer whether it worked or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for deduplicating log messages based on Message id.