Skip to content

Conversation

@Thomas-Gallant
Copy link
Contributor

@Thomas-Gallant Thomas-Gallant commented Mar 17, 2024

Changelog:

  • Updating readme with instructions for building android apk locally, setting up appium, and running tests with expo or apk
  • Updating so that SafeAreaProviderand SafeAreaView are only used once in the root of the app (removing duplication)
  • Setting safeareaview flex: 1 to fix bug with safeareaview not being respected in app, and setting color to default background color (see docs for explanation)
  • Adding appium/webdriver test profiles for android apk and android expo for real devices
  • Creating initial appium/webdriver test case for navigating to most areas of the app
  • using patch-package to patch a bug with wdio spec reporter output

Checklist for completing pull request:

  • Test functionality on Mobile, Web, and Desktop
  • Verify that any tests for new functionality are created and functional.
  • If needed, update the Readme

@github-actions
Copy link

🚀 Expo preview is ready!

  • Project → sudokuru
  • Platforms → android, ios
  • Scheme → sudokuru
  • Runtime Version → 0.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 76.86%. Comparing base (5e733a7) to head (2193af8).

Files Patch % Lines
app/Pages/PlayPage.tsx 28.57% 5 Missing ⚠️
app/Pages/DrillPage.tsx 0.00% 3 Missing ⚠️
app/Pages/LearnPage.tsx 66.66% 2 Missing ⚠️
app/Pages/StatisticsPage.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files          53       53           
  Lines        1245     1245           
  Branches      330      330           
=======================================
  Hits          957      957           
  Misses        278      278           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Preview Website for PR:
https://704e55aa.sudokuru-dev.pages.dev

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8312746058

Details

  • 3 of 10 (30.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.04%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Pages/LearnPage.tsx 1 2 50.0%
app/Pages/StatisticsPage.tsx 0 1 0.0%
app/Pages/DrillPage.tsx 0 2 0.0%
app/Pages/PlayPage.tsx 0 3 0.0%
Totals Coverage Status
Change from base Build 8223425463: 0.0%
Covered Lines: 753
Relevant Lines: 954

💛 - Coveralls

@Gregory711
Copy link
Contributor

as discussed would be good to document the error occurring when old sudokuru apk hasn't been uninstalled before trying to launch new one on device

@coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants