Skip to content

[Feature:System] Don't set given names to empty string #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2025
Merged

[Feature:System] Don't set given names to empty string #37

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbb5eae
[Fix:SQL] Prevent empty string values in user preferred given name du…
lavalleeale Jan 21, 2025
f354466
[Fix:SQL] Correct handling of user preferred given name in auto feed
lavalleeale Jan 22, 2025
e4ebc27
Fix:SQL] Prevent insertion of empty preferred given name in auto feed
lavalleeale Jan 22, 2025
dadedcb
Fix:SQL] Ensure proper handling of user preferred given name in auto …
lavalleeale Jan 23, 2025
32c10fd
Update ssaf_sql.php
lavalleeale Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions student_auto_feed/ssaf_sql.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ class sql {
user_familyname,
user_preferred_givenname,
user_email
) VALUES ($1, $2, $3, $4, $5, $6)
) VALUES ($1, $2, $3, $4, NULLIF($5,''), $6)
ON CONFLICT (user_id) DO UPDATE
SET user_numeric_id=EXCLUDED.user_numeric_id,
user_givenname=EXCLUDED.user_givenname,
user_familyname=EXCLUDED.user_familyname,
user_preferred_givenname=
CASE WHEN users.user_updated=FALSE
AND users.instructor_updated=FALSE
AND COALESCE(users.user_preferred_givenname, '')=''
AND users.user_preferred_givenname IS NULL
THEN EXCLUDED.user_preferred_givenname
ELSE users.user_preferred_givenname
END,
Expand Down
Loading