[Bugfix:System] Don't use -ofast for compilation #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
approved these changes
Aug 4, 2025
github-project-automation
bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
When compiling, the
-ofastflag is used even though it is not standards compliant and higher versions of clang will report errors withjson.hpp.What is the new behavior?
The
-o3flag is used instead to ensure runtime speed is still as fast as possible without causing errors.Other information?