[Bugfix:InstructorUI] Photo Scraper overhaul #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for non-instructors
dorian451
approved these changes
Jul 16, 2024
ziesski
requested changes
Jul 16, 2024
bmcutler
changed the title
bmcutler
requested changes
Jul 17, 2024
Member
bmcutler
left a comment
bmcutler
left a comment
There was a problem hiding this comment.
tested it, photoscraping works!
bmcutler
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the photo scraper to the latest Selenium and fixes the login process. For now, it also makes the scraper fetch CRNs from the SIS Class Search page. The purpose of doing this is to make the login functionality testable for non-instructors.