[YAML-tmLanguage] Remove empty capture group from multi-line match rule #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I'd be more confident about approving this if we had some syntax tests for YAML-tmLanguage... I will try to find time to try this change out locally within the next few days. Someone may beat me to it and that's fine 😉 |
|
@FichteFoll ping |
FichteFoll
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Thanks for taking a look at this very old comment that I totally do not remember writing but totally did (c6a170a).
I haven't looked at this syntax in years and only verified that your change doesn't break anything obvious, which it did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the rule for matching
match,begin, andendmulti-line blocks.