Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about roots in directory-package-mismatch rule #1303

Merged
merged 1 commit into from
Dec 17, 2024
Merged

docs: add note about roots in directory-package-mismatch rule #1303

merged 1 commit into from
Dec 17, 2024

Conversation

charlieegan3
Copy link
Member

Fixes #1300

anderseknert
anderseknert approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t have to be many sub-projects, but just that the policy root is somewhere else than in the project root :) But this is good!

@charlieegan3 charlieegan3 merged commit 8d0d888 into StyraInc:main Dec 17, 2024
5 checks passed
charlieegan3 added a commit to charlieegan3/regal that referenced this pull request Jan 6, 2025
@charlieegan3
docs: add note about roots in directory-package-mismatch rule (StyraI…
f90fc6f 
…nc#1303)

Fixes StyraInc#1300

Signed-off-by: Charlie Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderseknert anderseknert anderseknert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regal fix with directory-package-mismatch assumes root as base
2 participants
@charlieegan3 @anderseknert