Skip to content

Commit

Permalink
Merge pull request #826 from Stremio/feat/player-on-mute-show-0-volum…
Browse files Browse the repository at this point in the history
…e-on-slider

feat: Player - Volume slider - on muted show 0 volume
  • Loading branch information
tymmesyde authored Feb 7, 2025
2 parents 27b6942 + 4081396 commit 9cf8a39
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/routes/Player/ControlBar/ControlBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ const ControlBar = ({
<VolumeSlider
className={styles['volume-slider']}
volume={volume}
muted={muted}
onVolumeChangeRequested={onVolumeChangeRequested}
/>
<div className={styles['spacing']} />
Expand Down
9 changes: 6 additions & 3 deletions src/routes/Player/ControlBar/VolumeSlider/VolumeSlider.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const { useRouteFocused } = require('stremio-router');
const { Slider } = require('stremio/components');
const styles = require('./styles');

const VolumeSlider = ({ className, volume, onVolumeChangeRequested }) => {
const VolumeSlider = ({ className, volume, onVolumeChangeRequested, muted }) => {
const disabled = volume === null || isNaN(volume);
const routeFocused = useRouteFocused();
const [slidingVolume, setSlidingVolume] = React.useState(null);
Expand Down Expand Up @@ -45,7 +45,9 @@ const VolumeSlider = ({ className, volume, onVolumeChangeRequested }) => {
className={classnames(className, styles['volume-slider'], { 'active': slidingVolume !== null })}
value={
!disabled ?
slidingVolume !== null ? slidingVolume : volume
!muted ?
slidingVolume !== null ? slidingVolume : volume
: 0
:
100
}
Expand All @@ -61,7 +63,8 @@ const VolumeSlider = ({ className, volume, onVolumeChangeRequested }) => {
VolumeSlider.propTypes = {
className: PropTypes.string,
volume: PropTypes.number,
onVolumeChangeRequested: PropTypes.func
onVolumeChangeRequested: PropTypes.func,
muted: PropTypes.bool,
};

module.exports = VolumeSlider;

0 comments on commit 9cf8a39

Please sign in to comment.