Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated doc for 0.5.X #650

Open
wants to merge 20 commits into
base: branch-0.17.0-0.5
Choose a base branch
from

Conversation

lreciomelero
Copy link

Description

Se ha actualizado la documentación de la release 0.5, eliminando las referencias a los métodos de instalación de clusters sobre proveedores no soportados.

Related Pull Requests

Pull Request Checklist:

  • [PR title] Include a title referencing a ticket in Jira (e.g. "[CLOUDS-99] Implement a new funcionality").
  • [PR desc] Add a summary of the changes made in simple terms.
  • [PR desc] List any pull-request related to this change (docs, tests, feature, etc.).
  • [PR labels] Add the corresponding labels (release, skips, cherry-pick, AT-eks-smoke, etc).
  • [Docs] Are changes to the documentation required? (if so, please add references to those PRs).
  • [QA] Are new unit tests required according with the changes? (if so, please add references to those PRs).

@lreciomelero lreciomelero added documentation Improvements or additions to documentation ok-to-review 0.5.8 labels Jan 2, 2025
@lreciomelero lreciomelero requested a review from stg-0 as a code owner January 2, 2025 13:34
Copy link

@tperez-stratio tperez-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lreciomelero te devuelvo algunos cambios tras mi revisión. Por otro lado, has olvidado incluir los mismos ficheros de la carpeta EN para aplicar los mismos cambios a la versión en inglés (tanto las modificaciones en las páginas como la eliminación de algunas de ellas). Por favor, aplica los cambios si estás conforme y añade los cambios en inglés (de las traducciones me ocupo yo) y pide una nueva revisión.

Si tienes cualquier duda me dices. Gracias.

Copy link

@tperez-stratio tperez-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lreciomelero te respondo al comentario para que apliques el cambio si te parece bien.

stratio-docs/es/modules/ROOT/pages/installation.adoc Outdated Show resolved Hide resolved
Copy link

@tperez-stratio tperez-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lreciomelero he aplicado los cambios a la versión en inglés. Échales un ojo y, si ves todo OK, aprobamos para mergear. Gracias.

@@ -6,7 +6,7 @@

* For a user with the required privileges in AWS:
** Create a user for installation.
** Create a policy according to xref:attachment$stratio-aws-unmanaged-policy.json[_stratio-aws-unmanaged-policy.json_].
** Create a policy according to xref:attachment$stratio-eks-policy.json[_stratio-eks-policy.json_].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** Create a policy according to xref:attachment$stratio-aws-unmanaged-policy.json[stratio-aws-unmanaged-policy.json].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo este comentario @iamjanr, ¿quieres decir que el enlace correcto es el primero? Cuéntame.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me refiero a que esta cambiado aws-unmanaged-policy.json por stratio-eks-policy.json y hay que dejar aws-unmanaged-policy.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants