This repository was archived by the owner on Jun 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
Added EventHandler for UriChanging #46
Open
malscent
wants to merge
9
commits into
SteveSandersonMS:master
Choose a base branch
from
malscent:UrlChangeNotifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fbff90e
Linux Additions and functional
9d3e4d3
Windows change to add uri change callback
7a50d9d
Corrections for Windows testing
822800e
Updated windows and testasset
0f79179
fixed issue where update was coming before uri changed
96f33d9
wrong Navigate
ef0e6e3
Added EventHandler for UriChanging
e7d92cc
merge
9a2c452
Changed to unique_cotaskmem_string instead of PWSTR
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #import <Cocoa/Cocoa.h> | ||
| #import <WebKit/WebKit.h> | ||
| #include "WebWindow.h" | ||
|
|
||
| typedef void (*UriChangedCallback) (char* message); | ||
|
|
||
| @interface MyNavigationDelegate : NSObject <WKNavigationDelegate> { | ||
| @public | ||
| NSWindow * window; | ||
| WebWindow * webWindow; | ||
| UriChangedCallback uriChangedCallback; | ||
| } | ||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #import "WebWindow.Mac.NavigationDelegate.h" | ||
|
|
||
| @implementation MyNavigationDelegate : NSObject | ||
|
|
||
| - (void)webView:(WKWebView *)webView didStartProvisionalNavigation:(WKNavigation *)navigation; | ||
| { | ||
| [self callUriChangedCallback:webView.URL.absoluteString]; | ||
| } | ||
|
|
||
| - (void)webView:(WKWebView *)webView didFailNavigation:(WKNavigation *)navigation withError:(NSError *)error; | ||
| { | ||
| [self callUriChangedCallback:webView.URL.absoluteString]; | ||
| } | ||
|
|
||
| - (void)webView:(WKWebView *)webView | ||
| didReceiveServerRedirectForProvisionalNavigation:(WKNavigation *)navigation; | ||
| { | ||
| [self callUriChangedCallback:webView.URL.absoluteString]; | ||
| } | ||
|
|
||
| - (void) callUriChangedCallback: (NSString *) uri; | ||
| { | ||
| char* writableUri = (char*)[uri UTF8String]; | ||
| uriChangedCallback(writableUri); | ||
| } | ||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CoTaskMemFree comes from https://docs.microsoft.com/en-us/microsoft-edge/hosting/webview2/gettingstarted#step-4---navigation-events
Direction needed on whether it should be removed or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using
wil::unique_cotaskmem_string? It is just likeunique_ptrandCoTaskMemFreewill be called automatically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!