feat(core): support generating the tada files without the LSP active #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
d45790c to
8605083
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
ea9c555 to
9e52ad4
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
9e52ad4 to
2b10470
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
2b10470 to
26590f0
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
26590f0 to
aa36c11
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
aa36c11 to
42b20c7
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
3 times, most recently
from
a9f1218 to
58095aa
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
58095aa to
fb40913
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
fb40913 to
9595efc
Compare
JoviDeCroock
force-pushed
the
ensure-generating-tada
branch
from
9595efc to
22ceecf
Compare
mxstbr
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Do we want to just always do this to avoid people having to manually select the workspace TypeScript version? (Since VSCode doesn't let one do it automatically)
I know I've forgotten to set that setting and been like "Why doesn't this work?!" a few times myself 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought to my attention that JetBrains does not support the
tsserverplugins so this PR aims at supporting folks who leverage JetBrains or who can't switch to the workspace version of TypeScript