feat(core): Leverage gql.tada for typings
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoviDeCroock
force-pushed
the
gql-tada
branch
from
778e40e to
9f88d7a
Compare
JoviDeCroock
force-pushed
the
gql-tada
branch
2 times, most recently
from
4031799 to
e9ee558
Compare
JoviDeCroock
force-pushed
the
gql-tada
branch
from
e9ee558 to
3120259
Compare
JoviDeCroock
commented
Jan 16, 2024
packages/core/src/cli.ts
Outdated
| @@ -91,6 +91,7 @@ prog | |||
| } | |||
|
|
|||
| if (opts.client) { | |||
| // TODO: bail out when the user is using gql.tada | |||
There was a problem hiding this comment.
My thinking here is basically that we can check whether
- We have a valid
gql.tadainstallation - We have the config set in the
tsconfig
If the above don't hold up we need to codegen to support users with prior generated code
There was a problem hiding this comment.
This is beautiful for this migration for any early users we have. I'd love to be able to remove codegen entirely in v1.0!
JoviDeCroock
commented
Jan 16, 2024
JoviDeCroock
commented
Jan 16, 2024
mxstbr
approved these changes
Jan 16, 2024
| }) => { | ||
| const result = useFragment(SiteLocationFields, props.location) | ||
| const result = readFragment(SiteLocationFields, props.location) |
| @@ -10,9 +10,9 @@ const SiteLocationFields = graphql(` | |||
| `) | |||
|
|
|||
| export const Location = (props: { | |||
| location: FragmentType<typeof SiteLocationFields> | |||
| location: FragmentOf<typeof SiteLocationFields> | |||
JoviDeCroock
commented
Jan 17, 2024
| path.resolve(base, 'fuse/index.ts'), | ||
| `// This is a generated file!\n\nexport * from './tada';\nexport * from 'fuse/client';\n`, | ||
| ), | ||
| fs.writeFile(path.resolve(base, 'fuse/tada.ts'), tadaGqlContents), |
There was a problem hiding this comment.
In the future when folks use custom scalars, ... we might not want to override this
JoviDeCroock
commented
Jan 17, 2024
| }>() | ||
|
|
||
| export type { FragmentOf, ResultOf, VariablesOf } from 'gql.tada' | ||
| export type { FragmentOf as FragmentType } from 'gql.tada' |
There was a problem hiding this comment.
Added some aliases for backwards compat and docs clarity
SO GOOD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I am having here conceptually is that folks need
graphqlspto work correctly so that theintrospection.tsfile gets outputted correctly. Currently thinking whether we can establish a few safeguards here.The goal here is for new users to gain access to
gql.tadawhile former users don't have to change up their code and can stick to the LSP.I have updated the documentation with both a migrating to and disabling chunk.
Resolves #70