Skip to content

buildPublishTx endpoint incorrectly returns 201 Created #18

Description

@presidojay1

POST /events/:eventId/publish maps to buildPublishTx, which only simulates a Soroban call and returns { unsignedXdr } — no event or DB row is created (that happens later in confirm-publish). With no @HttpCode override, it defaults to 201 Created, which is misleading for a build-only operation.

Suggested fix: Import HttpCode, HttpStatus from @nestjs/common and add @HttpCode(HttpStatus.OK) above the buildPublishTx handler.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions