Skip to content

Build-transaction endpoints incorrectly return 201 Created #17

Description

@presidojay1

None of the build*Tx POST handlers declare an @HttpCode, so Nest's POST default of 201 Created applies even though these endpoints only simulate a Soroban call and return an unsigned XDR string — no resource is persisted.

Suggested fix: Import HttpCode, HttpStatus from @nestjs/common and add @HttpCode(HttpStatus.OK) to each build*Tx handler (leave the confirm-* handlers that actually create/update DB rows as-is).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions