fix: enforce 28-byte memo limit in send_payment and create_payment_request - #65
Open
DavidAkere204 wants to merge 1 commit into
Open
fix: enforce 28-byte memo limit in send_payment and create_payment_request#65DavidAkere204 wants to merge 1 commit into
DavidAkere204 wants to merge 1 commit into
Conversation
…quest - Add InvalidMemo = 26 variant to StellarSendError - Add MAX_MEMO_BYTES = 28 constant to stellar_send (mirrors Stellar classic MEMO_TEXT limit) - Reject memos exceeding MAX_MEMO_BYTES in send_payment via memo.len() > MAX_MEMO_BYTES guard - Reject memos exceeding MAX_MEMO_BYTES in create_payment_request with same guard - Update send_payment doc comment: 'recommended' → 'enforced' - Add test_send_payment_rejects_oversized_memo (29-byte memo → InvalidMemo) - Add test_send_payment_boundary_memo_succeeds (exactly 28 bytes → success) - Add test_create_payment_request_rejects_oversized_memo (500-byte memo → InvalidMemo) Closes StellarSend#49
DavidAkere204
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49