fix(fee_collector): add lifetime_withdrawn tracking and reconciliation view - #63
Open
DavidAkere204 wants to merge 1 commit into
Open
Conversation
…n view
- Add KEY_WITHDRAWN persistent storage key per token
- Update withdraw() to increment the lifetime-withdrawn counter on every
successful withdrawal (parallel to KEY_TOTAL / lifetime-collected)
- Add get_total_withdrawn(token) view function
- Add get_expected_balance(token) view function:
expected = get_total_collected(token) - get_total_withdrawn(token)
Diffing this against get_balance(token) surfaces any drift between
reported accounting and actual token holdings
- Update module doc comment to clearly state that get_total_collected is
a reported/claimed figure, not independently verified against real
token movement, and document the reconciliation invariant
- Add test_reconciliation_detects_divergence covering:
* normal collect + withdraw produces zero drift
* over-reported collect_fee (50 reported vs 30 received) produces a
detectable 20-token drift via get_expected_balance - get_balance
Closes StellarSend#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41