feat(ui): error display, network banner, env validation, and frontend README [UI #17, #18, #19, #20]#181
Merged
Tinna23 merged 1 commit intoStellarCommons:mainfrom Mar 24, 2026
Conversation
|
@Tyler7x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Tinna23
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Covers error handling polish, developer experience tooling, and documentation.
All four issues are grouped as they are non-blocking quality improvements
that don't depend on each other.
Changes
UI #17 — Shared ErrorDisplay component
src/components/ErrorDisplay.tsx— typed error display acceptingApiError | ErrorNOT_FOUND→ contextual message with truncated identifierUPSTREAM_ERROR→ network unreachable message with retry buttonBAD_REQUEST→ displays backend message directlysrc/app/tx/[hash]/page.tsx— replaced inline error div withErrorDisplaysrc/app/account/[address]/page.tsx— replaced inline error div withErrorDisplayError | nullto satisfy TypeScript strict modeloadextracted touseCallbackso retry can call it directlyUI #18 — Network status banner
src/components/NetworkStatusBanner.tsx— pollsGET /healthevery 60sstatus !== "ok"orhorizon_reachable === falsesrc/app/layout.tsxUI #19 — Environment variable validation
src/lib/env.ts—requireEnv()throws in dev if missing, warns in prodAPI_URLvalidated before any proxy route runsAPI_URLfrom@/lib/env.env.local.exampleupdated with all variables documentedUI #20 — Frontend README
packages/ui/README.md— full rewrite (previous file contained backend Rust docs)structure, connecting to backend (Cargo and Docker), architecture notes
(proxy pattern, AppShell context, route table)
How to test
Closes
Closes #165
Closes #166
Closes #167
Closes #168