test(registry): remove-compact-reregister counter parity at scale - #357
Merged
miss-yusrah merged 1 commit intoAug 31, 2026
Conversation
Issue Stellar-TrustBridge#93/Stellar-TrustBridge#110 are small; combined with compact_index the count, verified count, and chunked index can drift. Add a scale-ish scenario that fills several chunks, removes a middle band, compacts, re-registers the same names, then asserts count/vcount/index all agree with the live records. Document the invariant (I10) in REGISTRY_INVARIANTS.md.
|
@syndeybof-oss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove-then-register counter parity under chunk compaction at scale
Problem
#93 and #110 are individually small, but combined with
compact_indextheflat index, the chunked index, and the
count/vcountcounters can driftapart. There was no test that:
count,vcount, and the index all agree.What this adds
A scale-ish scenario test
(
test_issue306_remove_compact_reregister_counter_parityintests/integration.rs) that:CHUNK_SIZEchunk boundaries),vcountis non-trivial,get_stats().total,get_verified_count(), the chunked index,and a full paginated export all agree with the live record set.
Also adds invariant I10 to
docs/REGISTRY_INVARIANTS.mddocumenting theparity guaranteed by this scenario.
No drift was found — the scenario passes.
Closes #306
Closes #303
Closes #304
Closes #305