Devoclan/proof and c2c deny - #350
Merged
miss-yusrah merged 2 commits intoAug 31, 2026
Merged
Conversation
verify() is currently "admin said so" with no proof bytes. Adds OracleProof + set_oracle_allowlist/get_oracle_allowlist/verify_with_proof in src/oracle_proof.rs: an allowlisted Ed25519 oracle key signs a message off-chain, and the contract checks allowlist membership, expiry, and the signature. Invalid proofs fail (NotAuthorized for unallowlisted/expired keys, a host trap for a bad signature, mirroring existing require_auth() behavior). Covered by tests using a fixed test keypair. Out of scope (documented in docs/SECURITY.md): wiring this into verify()/batch_verify(), and running a production GitHub oracle. Still not a GitHub API integration.
register() has no replay nonce, and C2C write access was unspecified. Rather than half-opening C2C register, adds tests/cross_contract_register_deny.rs proving a sibling contract cannot relay a register() call on another address's behalf: the relaying contract runs in its own auth context and cannot satisfy stellar_address.require_auth(), so the call fails closed. A positive control confirms direct, self-signed register still works. docs/SECURITY.md documents the ABI statement: register is not part of the cross-contract read surface and must not be added to it without a replay nonce shipped in the same change.
|
@devoclan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #312
closes #313
closes #314
closes #315