Rate limiting module per user per ip and global throttling with redis - #383
Open
SugaretaNajja wants to merge 2 commits into
Conversation
Create Portfolio REST API Endpoints
Rate limiting module: per-user, per-IP, and global throttling with Redis
Contributor
|
@this too |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description — Develop Core Rebalancing Engine with Drift Detection
Summary
This PR implements the core portfolio rebalancing engine for detecting allocation drift, determining when rebalancing is required, calculating the necessary trades, and executing rebalancing operations.
The implementation also adds simulation support, atomic execution, rebalancing history, and handling for key edge cases such as insufficient liquidity, single-asset portfolios, and zero balances.
Changes
calculate_portfolio_drift()to calculate deviations between current and target portfolio allocations.detect_rebalancing_need()with configurable drift thresholds.calculate_rebalance_trades()to determine the required buy and sell operations.execute_rebalance()for atomic multi-step rebalancing operations.Acceptance Criteria
Testing
Testing covers:
Expected Outcome
The contract can reliably detect portfolio drift and determine the trades required to restore target allocations. Rebalancing can be executed atomically or previewed through simulation mode while maintaining accurate history and safely handling edge cases.
Closes #366