Skip to content

Use different IP addresses for the out-of-the-box "virtualbox" variants #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Use different IP addresses for the out-of-the-box "virtualbox" variants #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Vagrantfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ Vagrant.configure("2") do |config|
config.vm.define "2016-box", autostart: false do |cfg|
cfg.vm.box = "StefanScherer/windows_2016_docker"
cfg.vm.provision "shell", path: "scripts/create-machine.ps1", args: "-machineHome #{home} -machineName 2016-box"
cfg.vm.provider "virtualbox" do |v, override|
override.vm.network :private_network, ip: "192.168.59.50", gateway: "192.168.56.1"
end
end

config.vm.define "1709", autostart: false do |cfg|
Expand Down Expand Up @@ -48,6 +51,9 @@ Vagrant.configure("2") do |config|
config.vm.define "2019-box", autostart: false do |cfg|
cfg.vm.box = "StefanScherer/windows_2019_docker"
cfg.vm.provision "shell", path: "scripts/create-machine.ps1", args: "-machineHome #{home} -machineName 2019-box"
cfg.vm.provider "virtualbox" do |v, override|
override.vm.network :private_network, ip: "192.168.59.51", gateway: "192.168.56.1"
end
end

config.vm.define "2022", autostart: false do |cfg|
Expand All @@ -58,6 +64,9 @@ Vagrant.configure("2") do |config|
config.vm.define "2022-box", autostart: false do |cfg|
cfg.vm.box = "StefanScherer/windows_2022_docker"
cfg.vm.provision "shell", path: "scripts/create-machine.ps1", args: "-machineHome #{home} -machineName 2022-box"
cfg.vm.provider "virtualbox" do |v, override|
override.vm.network :private_network, ip: "192.168.59.52", gateway: "192.168.56.1"
end
end

config.vm.define "insider", autostart: false do |cfg|
Expand Down Expand Up @@ -96,7 +105,6 @@ Vagrant.configure("2") do |config|
v.customize ["modifyvm", :id, "--nested-hw-virt", "on"]
# Use the recommended paravirtualization interface for windows (hyperv) - requires VirtualBox 6
v.customize ["modifyvm", :id, "--paravirtprovider", "hyperv"]
override.vm.network :private_network, ip: "192.168.59.90", gateway: "192.168.56.1"
Copy link
Contributor Author

@amotl amotl Jun 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed this line over here, because we didn't take the time to validate override order yet, i.e. how the code would behave when it would have been left in place. Do you think our amendments re. "per-box-IP" would still take precedence?

However, it might introduce a regression because all the NON-"out-of-the-box" boxes will now be invoked without this configuration setting.

Please let us know if this detail should be addressed in one way or another beforehand. We see three options:

  • Check/verify override order. If the individual assignments take precedence, then this line can be left in place.
  • Explicitly assign IP addresses to all of the other machines as well.
  • Investigate if there is another, more advanced way of configuring the IP address assignment automatically.

Copy link
Contributor Author

@amotl amotl Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GH-89 possibly related?

/cc @gabyx

end

config.vm.provider "hyperv" do |v|
Expand Down