add Rule0095: avoid unused parameters in internal procedures#1195
Open
iwanscheidsnc wants to merge 1 commit intoStefanMaron:prereleasefrom
Open
add Rule0095: avoid unused parameters in internal procedures#1195iwanscheidsnc wants to merge 1 commit intoStefanMaron:prereleasefrom
iwanscheidsnc wants to merge 1 commit intoStefanMaron:prereleasefrom
Conversation
Contributor
Author
|
@StefanMaron No rush at all, but I wanted to check if you have an estimate on when you might be able to review this PR. Happy to adjust anything as needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeCop Warning AA0137 (
https://learn.microsoft.com/de-de/dynamics365/business-central/dev-itpro/developer/analyzers/codecop-aa0137?wt.mc_id=d365bc_inproduct_alextension
) already detects unused parameters in local procedures. This rule extends this check to internal procedures as well. Since internal procedures can be adjusted with minimal effort and without breaking changes, unused parameters in these procedures should be cleaned up too.