Open
Conversation
Collaborator
|
just a note that Eremel said they are going to change the sticker application API, in case you wanted to discuss |
Contributor
Author
I remember hearing this at some point. I foresee these functions persisting in some shape or form when he does touch on it, hence why I made the PR now instead of waiting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows better functionality when applying and removing stickers. Runs two new contexts
apply_sticker = trueandremove_sticker = truealong with the card and sticker.apply_stickercontext also differentiates between stickers applied to cards by the game (i.e. higher stake shops and challenges) and stickers applied by modded objects. Done via global valueSMODS.sticker_from_gameAlso overrides vanilla sticker applying functions (e.g. Card:set_eternal) to use SMODS funcs instead to allow for backwards compatibility
Additional Info: