Add apply, remove and set_ability functions to Seals#907
Open
bepisfever wants to merge 2 commits intoSteamodded:mainfrom
Open
Add apply, remove and set_ability functions to Seals#907bepisfever wants to merge 2 commits intoSteamodded:mainfrom
bepisfever wants to merge 2 commits intoSteamodded:mainfrom
Conversation
Contributor
|
It would be nice to be able to distinguish between calling cases. For example with removed: being able to differentiate the seal being replaced from the card with the seal being destroyed. |
Collaborator
|
as always, naming concerns: apply/remove/set_ability don't really match with what they actually do. I propose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seals now have:
apply(self, card): Runs when the Seal is applied on an obtained card, or when the card with the Seal is obtained.remove(self, card): Runs when the card with the seal is removed, or when the seal is removed.set_ability(self, card): Runs when the Seal is applied on a card.I also added a hook that adds
added_to_deckto all playing cards at the start of run.Wiki PR update: Steamodded/Wiki#53
Additional Info: