calc_interest, and variables to better modify interest#876
Open
bepisfever wants to merge 6 commits intoSteamodded:mainfrom
Open
calc_interest, and variables to better modify interest#876bepisfever wants to merge 6 commits intoSteamodded:mainfrom
bepisfever wants to merge 6 commits intoSteamodded:mainfrom
Conversation
Collaborator
|
Very reasonable, making interest easy to modify is a good idea. I remember the getter contexts thing; that seems applicable to this, you may need to update this PR. About API structure: I am concerned about Card:calculate_interest(), because you're adding on another function onto every card. It feels a bit unnatural. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 2 global variables that can be changed to modify interest more easily without modifying the behavior of vanilla interest-related variables.
G.GAME.extra_interest_cap: Adds onto the current interest cap.G.GAME.extra_per_interest: Adds onto the amount of money per $1 interest.SMODS.get_interest()is added, which returns the total interest cap, and total cash per interest.And Jokers can now have
calc_interest(card):add_capwill increase interest cap by that amount.add_per_interestwill increase cash per interest by that amount.Additional Info: