SMODS.should_keep_on_use for finer control over keep_on_use#1178
Open
borb43 wants to merge 3 commits intoSteamodded:mainfrom
Open
SMODS.should_keep_on_use for finer control over keep_on_use#1178borb43 wants to merge 3 commits intoSteamodded:mainfrom
borb43 wants to merge 3 commits intoSteamodded:mainfrom
Conversation
Member
|
The more practical approach would probably to either integrate keep_on_use into the using consumable context or make a new context for it. Hookables for effects like this aren't all that desirable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SMODS.should_keep_on_use(card), which now handles calling a center'skeep_on_use. This can be hooked to more easily allow external effects to keep used consumables, whereas previously all mods would have to patch the same piece of code to achieve this.Additional Info: