Allow calc_scaling to apply to editions#1014
Open
jumbocarrot0 wants to merge 1 commit intoSteamodded:mainfrom
Open
Allow calc_scaling to apply to editions#1014jumbocarrot0 wants to merge 1 commit intoSteamodded:mainfrom
jumbocarrot0 wants to merge 1 commit intoSteamodded:mainfrom
Conversation
Collaborator
|
alright, agreed that this is a good addition. I'm concerned (outside of this specific PR) that we have many different things happening in calc, each of which is passed to an inconsistent subset of objects. Better Calc is good at passing things to every relevant cardarea but there still are gaps |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small bit of code to
SMODS.scale_cardthat checks if any cards have an edition with thecalc_scalingfunction. This allows editions to modify the scaling effect of cards like jokers can.Additional Info: