-
-
Notifications
You must be signed in to change notification settings - Fork 91
PKGBUILD - patch so it can build. #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKGBUILD - patch so it can build. #563
Conversation
|
Oddly enough, I've spotted a few other errors. The compilation location seems to be nested in src/millennium_x86-build/ here, and for bootstrap it's in src/millennium_x86-build/boot/. |
42f3b4f to
cd0809a
Compare
|
Currently, this PKGBUILD works perfectly! See my millennium-git package on the AUR! |
I think you missed copying the assets folder |
|
Oh darn! Do we need to copy both sdk and frontend or just one? frontend is just for frontend.bin right? Which gets built into the package, I think, so just sdk? |
|
Thanks for the recent help, its much appreciated! |
Right, that's perfect, I'll push the copy for assets, and then we can merge >:3 And no worries, always happy to help a fun project :3 |
|
I FOUND IT, ignore me, lemme push that change now! |
It should be /src/pipx/ |
Resetted branch to next first. Signed-off-by: ninetailedtori <[email protected]>
07dc3bc to
2b44139
Compare
|
Noooo wait I just fucked up, I just reset the wrong branch coz I wasn't looking carefully, lemme redo the changes GUH |
You know, I did this twice, because i accidentally reset this branch qwq Signed-off-by: ninetailedtori <[email protected]>
|
Sometimes I realise just how much I really just was born for immutable VCS, and it's these moments really |
|
Well, this should be everything, it's completely ok to build now! |
Signed-off-by: ninetailedtori <[email protected]>
|
Wait, shoot, lemme push some fixes to this LOL. I'll open a new PR, weird naming issues when globbing qwq Don't revert though, it's cool as is |
|
🎉 This PR is included in version 2.31.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
It seems redundant, now that assets are included within the frontend, and hosted elsewhere, that we don't need to build them externally outside of frontend and sdk, thus we should just scrap the line in the PKGBUILD.