Skip to content

Conversation

@ninetailedtori
Copy link

It seems redundant, now that assets are included within the frontend, and hosted elsewhere, that we don't need to build them externally outside of frontend and sdk, thus we should just scrap the line in the PKGBUILD.

@ninetailedtori
Copy link
Author

ninetailedtori commented Dec 8, 2025

Oddly enough, I've spotted a few other errors. The compilation location seems to be nested in src/millennium_x86-build/ here, and for bootstrap it's in src/millennium_x86-build/boot/.

@ninetailedtori ninetailedtori changed the title PKGBUILD - Remove mk-assets.sh entirely. PKGBUILD - patch so it can build. Dec 8, 2025
@ninetailedtori
Copy link
Author

Currently, this PKGBUILD works perfectly! See my millennium-git package on the AUR!

@xBiei
Copy link

xBiei commented Dec 9, 2025

Currently, this PKGBUILD works perfectly! See my millennium-git package on the AUR!

I think you missed copying the assets folder (/usr/share/millennium/assets), I had to do it manually to be able to start steam

@ninetailedtori
Copy link
Author

ninetailedtori commented Dec 9, 2025

Oh darn! Do we need to copy both sdk and frontend or just one? frontend is just for frontend.bin right? Which gets built into the package, I think, so just sdk?

@shdwmtr
Copy link
Member

shdwmtr commented Dec 9, 2025

assets right now only needs pipx (src/frontend) which is a compat tool for python plugins (we are moving from python to lua, but need a couple buffer releases where both lua and python are supported). But yes, you are correct! Nothing else needs to be in assets since sdk AND frontend are statically compiled into the binary now.

Thanks for the recent help, its much appreciated!

@ninetailedtori
Copy link
Author

assets right now only needs pipx (src/frontend) which is a compat tool for python plugins (we are moving from python to lua, but need a couple buffer releases where both lua and python are supported). But yes, you are correct! Nothing else needs to be in assets since sdk AND frontend are statically compiled into the binary now.

Thanks for the recent help, its much appreciated!

Right, that's perfect, I'll push the copy for assets, and then we can merge >:3

And no worries, always happy to help a fun project :3

@ninetailedtori
Copy link
Author

I FOUND IT, ignore me, lemme push that change now!

@xBiei
Copy link

xBiei commented Dec 9, 2025

I can't actually find the pipx tool within frontend, do I need to just clone the entire folder over? Or wait, did I misunderstand, has next moved away from pipx? xD

It should be /src/pipx/

Resetted branch to next first.

Signed-off-by: ninetailedtori <[email protected]>
@ninetailedtori
Copy link
Author

Noooo wait I just fucked up, I just reset the wrong branch coz I wasn't looking carefully, lemme redo the changes GUH

You know, I did this twice, because i accidentally reset this branch qwq

Signed-off-by: ninetailedtori <[email protected]>
@ninetailedtori
Copy link
Author

ninetailedtori commented Dec 9, 2025

Sometimes I realise just how much I really just was born for immutable VCS, and it's these moments really

@ninetailedtori
Copy link
Author

ninetailedtori commented Dec 9, 2025

Well, this should be everything, it's completely ok to build now!

Signed-off-by: ninetailedtori <[email protected]>
@shdwmtr shdwmtr merged commit 99b1aec into SteamClientHomebrew:next Dec 9, 2025
@ninetailedtori
Copy link
Author

ninetailedtori commented Dec 9, 2025

Wait, shoot, lemme push some fixes to this LOL. I'll open a new PR, weird naming issues when globbing qwq

Don't revert though, it's cool as is

@github-actions
Copy link

🎉 This PR is included in version 2.31.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants