Skip to content

Support for Clang compiler (unwrap variadic arguments), fix code errors thrown by -Wpedantic. #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shdwmtr merged 2 commits into from
Dec 9, 2025
Merged

Support for Clang compiler (unwrap variadic arguments), fix code errors thrown by -Wpedantic. #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
231b31a
Move -s (strip symtab) to linker flags.
ninetailedtori Dec 7, 2025
ae54bf8
Add VA_ARGS expansion for Clang support. Remove user-defined copy con…
ninetailedtori Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug")
endif()

if(UNIX AND CMAKE_BUILD_TYPE STREQUAL "Release")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -s")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -s")
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS OFF)
set(CMAKE_BUILD_TYPE_INIT "Release")
set(CMAKE_C_FLAGS_RELEASE "-DNDEBUG -Oz -ffunction-sections -fdata-sections")
Expand Down
3 changes: 0 additions & 3 deletions src/include/millennium/backend_init.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ class BackendCallbacks : public Singleton<BackendCallbacks>
PluginTypeSchema(const std::string& name, eBackendLoadEvents ev) : pluginName(name), event(ev)
{
}
PluginTypeSchema(const PluginTypeSchema& other) : pluginName(other.pluginName), event(other.event)
{
}
};

using EventCallback = std::function<void()>;
Expand Down
13 changes: 12 additions & 1 deletion src/include/millennium/logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,16 @@ extern OutputLogger Logger;
#endif

#ifndef LOG_ERROR
#define LOG_ERROR(fmt, ...) Logger.ErrorTrace(fmt, __FILE__, __LINE__, PRETTY_FUNCTION, ##__VA_ARGS__)
#define LOG_ERROR(...) Logger.ErrorTrace(FIRST(__VA_ARGS__), __FILE__, __LINE__, PRETTY_FUNCTION REST(__VA_ARGS__))
#define FIRST(...) FIRST_HELPER(__VA_ARGS__, throwaway)
#define FIRST_HELPER(first, ...) first
#define REST(...) REST_HELPER(NUM(__VA_ARGS__), __VA_ARGS__)
#define REST_HELPER(qty, ...) REST_HELPER2(qty, __VA_ARGS__)
#define REST_HELPER2(qty, ...) REST_HELPER_##qty(__VA_ARGS__)
#define REST_HELPER_ONE(first)
#define REST_HELPER_TWOORMORE(first, ...) , __VA_ARGS__
#define NUM(...) \
SELECT_10TH(__VA_ARGS__, TWOORMORE, TWOORMORE, TWOORMORE, TWOORMORE,\
TWOORMORE, TWOORMORE, TWOORMORE, TWOORMORE, ONE, throwaway)
#define SELECT_10TH(a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, ...) a10
#endif