fix(s9pk): normalize JavaScript ingredient permissions - #3617
Open
BeeJoe wants to merge 2 commits into
Open
Conversation
BeeJoe
marked this pull request as ready for review
August 2, 2026 02:44
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ugo+rX) without mutating the source tree or stripping executable bits.pack(): the regression re-executes under umask077, builds a real.s9pk, extractsjavascript.squashfs, and verifies both archive and source modes.CONTRIBUTING.mdtoAGENTS.mdmigration without duplicating root-owned prerequisites.Previously, a restrictive packager umask could embed
0700JavaScript directories and a0600index.js, causing StartOS to report/usr/lib/startos/package/index.js not foundfor an otherwise valid package.Supersedes #3587.
Master merge and conflict resolution
Merged current
Start9Labs/masterat6a1f75d6cin8f501afb5.projects/start-cli/CHANGELOG.mdby retaining the authcookie fix already on master and adding the s9pk permission fix under the existing unreleased1.1.1heading.projects/start-os/CHANGELOG.mdby retaining all current0.4.0.2entries, including the notification fix from fix(ui): align mobile notification checkboxes #3616, and adding the s9pk permission fix.0.4.0.2manifest, migration, lockfile, release-link, and generated man-page changes now supplied by fix(ui): align mobile notification checkboxes #3616. Those files are byte-identical to master in the effective PR diff.0.4.0.2while the old comment named0.4.0.1specifically.Verification
Original branch verification before the master merge:
make start-core-test: 257 passed, 0 failed, 3 ignoredcargo check -p start-os -p start-corecargo check --tests -p start-core --features=testmake manpages: 4 passedmdbook buildinprojects/start-os/docsPost-merge verification on
8f501afb5:cargo check --tests -p start-core --features=testcargo check -p start-os -p start-corecargo fmt --all --checkmdbook buildinprojects/start-os/docsmdbook buildinprojects/start-sdk/docsbuild/builder-alias.shandshared-libs/crates/start-core/run-tests.shgit diff upstream/master --checkThe post-merge focused runtime rerun was stopped while still compiling the repository test binary under the optimized test profile; it produced no test failure and never reached the harness. The test target typechecks on the merged tree, and the unchanged focused regression passed before the merge.