Audit and harden packaging; native sign-up + password recovery - #1
Merged
Conversation
Conformance + correctness pass against the canonical start9-registry packages, plus a restart fix and an account-recovery flow. Correctness: - Remove runAsInit from every daemon. These images are plain application-binary entrypoints (postgres, valkey, node, caddy), not s6/tini images, so runAsInit is a misuse: it wrapped node in an init shim that was orphaned on restart, leaving the old server holding :3000 and the new one crash-looping on EADDRINUSE (reproducible on a single restart). Removing it fixes the loop. - Back up Postgres with withPgDump instead of a raw volume copy (portable across Postgres major upgrades). - Bind Postgres to 127.0.0.1; drop the server's unused volume mount. Conformance: - Dedicated db volume for Postgres, startos volume for store.json (was one main volume). - Redis -> Valkey (valkey/valkey:8-alpine), ephemeral. - Hide internal Postgres/Valkey health checks (display: null). - packageRepo -> Start9-Community; CONTRIBUTING/TODO aligned; effects: T.Effects. Accounts: - Registration on by default so the first account is created in the native web UI; an important task reminds the user to disable open sign-ups afterward. - New Reset Account Password action: pick an account from a dynamic dropdown and get a freshly generated password (hashed with the app's own argon2, written to Postgres). The only recovery path, since upstream has no forgotten-password flow and passkeys are address-bound. - Registrations toggle action to open/close sign-ups. Follow-up in TODO.md: once dsbaars/bunker46#9 (first-user bypass) lands, default registration off and drop the disable-registration task. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MattDHill
approved these changes
Jun 17, 2026
Contributor
Author
|
Thanks for the review, @MattDHill! No change requests, so nothing further to address on my end. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit + update of the community
bunker46-startospackage against the canonical start9-registry packages — correctness, conformance, and an account-recovery flow.Correctness
runAsInitfrom all daemons. bunker46's images are plain application-binary entrypoints (postgres, valkey, node, caddy), not s6/tini images, sorunAsInitwas a misuse — it orphaned the node server on restart, leaving it holding:3000and crash-looping onEADDRINUSE(reproducible on a single restart).withPgDump(portable across PG major upgrades).127.0.0.1; dropped the server's unused volume mount.Conformance
dbvolume +startosvolume (was onemainvolume).valkey/valkey:8-alpine), ephemeral.display: null).packageRepo→ Start9-Community; CONTRIBUTING/TODO aligned to canonical;effects: T.Effects.Accounts
Built, installed, and exercised on a StartOS dev box: clean boot, native sign-up, password reset + login (old password invalidated), and restart with no
EADDRINUSE.Follow-up tracked in
TODO.md: once upstream dsbaars/bunker46#9 (first-user bypass) lands and the ref is bumped, default registration off and drop the disable-registration task.🤖 Generated with Claude Code