fix warnings; keep Cargo.lock; clippy with -D warnings

.github/workflows/ci.yml

@@ -22,6 +22,6 @@ jobs:
     - name: Check code format
       run: cargo fmt --all -- --check
     - name: Clippy
-      run: cargo clippy --target ${{ matrix.targets }} --all-features -- -A clippy::new_without_default
+      run: cargo clippy --target ${{ matrix.targets }} --all-features -- -D warnings
     - name: Build
-      run: cargo build --target ${{ matrix.targets }} --all-features
+      run: cargo build --target ${{ matrix.targets }} --all-features

.gitignore

@@ -3,10 +3,6 @@
 debug/
 target/
 
-# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
-# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
-Cargo.lock
-
 # These are backup files generated by rustfmt
 **/*.rs.bk
 

src/gic_v3.rs

@@ -202,18 +202,18 @@ impl GicDistributor {
 
     fn mpidr_affinity_level(mpidr: u64, level: u32) -> u64 {
         match level {
-            3 => mpidr >> 32 & 0xff,
-            2 => mpidr >> 16 & 0xff,
-            1 => mpidr >> 8 & 0xff,
+            3 => (mpidr >> 32) & 0xff,
+            2 => (mpidr >> 16) & 0xff,
+            1 => (mpidr >> 8) & 0xff,
             0 => mpidr & 0xff,
             _ => panic!("invalid affinity level"),
         }
     }
 
     fn mpidr_to_affinity_level(mpidr: u64) -> u64 {
-        Self::mpidr_affinity_level(mpidr, 3) << 32
-            | Self::mpidr_affinity_level(mpidr, 2) << 16
-            | Self::mpidr_affinity_level(mpidr, 1) << 8
+        (Self::mpidr_affinity_level(mpidr, 3) << 32)
+            | (Self::mpidr_affinity_level(mpidr, 2) << 16)
+            | (Self::mpidr_affinity_level(mpidr, 1) << 8)
             | Self::mpidr_affinity_level(mpidr, 0)
     }
 
@@ -327,7 +327,7 @@ impl GicRedistributor {
 
     fn base_init(&mut self) {
         let typer = self.gicr_regs().TYPER.get() as usize;
-        let mut ppinum = typer >> 27 & 0x1f;
+        let mut ppinum = (typer >> 27) & 0x1f;
         ppinum = match ppinum {
             0 => 16,
             1 | 2 => 16 + 32 * ppinum,

src/lib.rs

@@ -12,9 +12,6 @@
 //! Please contact the developer if you need this function
 
 #![no_std]
-#![feature(const_ptr_as_ref)]
-#![feature(const_option)]
-#![feature(const_nonnull_new)]
 
 use core::fmt;
 use core::fmt::{Debug, Formatter};