Feature/initialize escrow #179
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,9 +18,10 @@ import { BuyerRequestsModule } from './modules/buyer-requests/buyer-requests.mod | |
| import { OffersModule } from './modules/offers/offers.module'; | ||
| import { EscrowModule } from './modules/escrow/escrow.module'; | ||
| import { SupabaseModule } from './modules/supabase/supabase.module'; | ||
| import { AppCacheModule } from './cache/cache.module'; | ||
| import { StoresModule } from './modules/stores/stores.module'; | ||
| import { TrustlessWorkModule } from './modules/trustlessWork/trustless-work.module'; | ||
| import { EscrowsModule } from './modules/escrows/escrows.module'; | ||
|
|
||
| // Entities | ||
| import { User } from './modules/users/entities/user.entity'; | ||
|
|
@@ -45,13 +46,15 @@ import { Milestone } from './modules/escrow/entities/milestone.entity'; | |
| import { Escrow } from './modules/escrow/entities/escrow.entity'; | ||
| import { EscrowFundingTx } from './modules/escrow/entities/escrow-funding-tx.entity'; | ||
| import { Store } from './modules/stores/entities/store.entity'; | ||
| import { Escrow as EscrowV2 } from './modules/escrows/entities/escrow.entity'; | ||
| import { Milestone as MilestoneV2 } from './modules/escrows/entities/milestone.entity'; | ||
|
Comment on lines
+49
to
+50
There was a problem hiding this comment. 🧩 Analysis chainClarify the dual entity architecture. Aliasing entities as Run the following script to verify the table names configured for these entities: If the entities target the same tables, this will cause schema conflicts. Consider:
🏁 Script executed: #!/bin/bash
# Description: Check @Entity decorator table names for all Escrow and Milestone entities
echo "=== Old Escrow entity ==="
ast-grep --pattern $'@Entity($$$)
export class Escrow $$$'
echo -e "\n=== New Escrow (EscrowV2) entity ==="
ast-grep --pattern $'@Entity($$$)
export class Escrow $$$' ./src/modules/escrows/entities/escrow.entity.ts
echo -e "\n=== Old Milestone entity ==="
ast-grep --pattern $'@Entity($$$)
export class Milestone $$$'
echo -e "\n=== New Milestone (MilestoneV2) entity ==="
ast-grep --pattern $'@Entity($$$)
export class Milestone $$$' ./src/modules/escrows/entities/milestone.entity.tsLength of output: 137 🏁 Script executed: #!/bin/bash
echo "=== escrow.entity.ts files and @Entity decorators ==="
fd "escrow.entity.ts" -x sh -c 'echo "-- File: {}"; rg -n "@Entity" {} || echo "No @Entity found"'
echo -e "\n=== milestone.entity.ts files and @Entity decorators ==="
fd "milestone.entity.ts" -x sh -c 'echo "-- File: {}"; rg -n "@Entity" {} || echo "No @Entity found"'Length of output: 443 Escrow entities conflict on the same table
🤖 Prompt for AI Agents |
||
|
|
||
| @Module({ | ||
| imports: [ | ||
| ConfigModule.forRoot({ | ||
| isGlobal: true, | ||
| envFilePath: ['.env'], | ||
| }), | ||
| ScheduleModule.forRoot(), | ||
| AppCacheModule, | ||
| TypeOrmModule.forRoot({ | ||
|
|
@@ -78,12 +81,11 @@ import { EscrowsModule } from './modules/escrows/escrows.module'; | |
| OfferAttachment, | ||
| EscrowAccount, | ||
| Milestone, | ||
| Escrow, | ||
| EscrowFundingTx, | ||
| Store, | ||
| EscrowV2, | ||
| MilestoneV2, | ||
| ], | ||
| synchronize: false, | ||
| logging: process.env.NODE_ENV === 'development', | ||
|
|
@@ -103,9 +105,9 @@ import { EscrowsModule } from './modules/escrows/escrows.module'; | |
| OffersModule, | ||
| EscrowModule, | ||
| SupabaseModule, | ||
| TrustlessWorkModule, | ||
| StoresModule, | ||
| EscrowsModule, | ||
| ], | ||
| }) | ||
| export class AppModule { } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deduplicate and order TRUSTLESS_WORK_ keys*
You added TRUSTLESS_WORK_ENV twice and placed TRUSTLESS_WORK_BASE_URL after it. This can mislead users and break dotenv linters.
Apply this diff:
Optional: document valid values for TRUSTLESS_WORK_ENV (development|testnet|production).
📝 Committable suggestion
🧰 Tools
🪛 dotenv-linter (3.3.0)
[warning] 20-20: [DuplicatedKey] The TRUSTLESS_WORK_ENV key is duplicated
(DuplicatedKey)
[warning] 21-21: [UnorderedKey] The TRUSTLESS_WORK_BASE_URL key should go before the TRUSTLESS_WORK_ENV key
(UnorderedKey)
🤖 Prompt for AI Agents