STAC-23523: wiring deduplication in the mapping handler #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb3ckers
reviewed
Dec 17, 2025
rb3ckers
reviewed
Dec 17, 2025
rb3ckers
reviewed
Dec 17, 2025
rb3ckers
reviewed
Dec 17, 2025
rb3ckers
reviewed
Dec 17, 2025
Return 'empty' ExpressionRefSummary when there are no datapoint, span or metric expressions in a mapping Add tests to ensure we catch changes to the mappings model - so we explicitly can decide to walk or skip a new field Drop vars from the ExpressionRefSummary
Ensure we also tag mappings using the entire attribute map as source
Don't skip resource/scope only mappings in dedup Swap rune-ascii based int hash with binary hash Shorten string annotations to single chars Ensure attributes targetted by tag mapping source can get hashed entirely
deontaljaard
force-pushed
the
stac-23523-dedup-impl-and-hasher
branch
from
fcaae9f to
0d1f596
Compare
Pass expressionrefmanager instance to the deduplicator and prevent passing around expression ref summaries
deontaljaard
force-pushed
the
stac-23523-dedup-wiring-it-all-together
branch
from
e808f30 to
0ffe893
Compare
rb3ckers
previously approved these changes
Dec 19, 2025
deontaljaard
commented
Dec 19, 2025
deontaljaard
changed the base branch from
stac-23523-dedup-impl-and-hasher
to
main
rb3ckers
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.