Skip to content

Conversation

@LouisParkin
Copy link

No description provided.

Copy link

@deontaljaard deontaljaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remark, otherwise LGTM.

uses: actions/setup-go@v5
with:
go-version: 1.24.6
go-version: 1.24.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test workflow looks like it needs to be aligned? https://github.com/StackVista/minio-mc/blob/main/.github/workflows/go.yml#L20

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deontaljaard I considered it for a moment, but since the test passed, I figured it doesn't really matter.

@LouisParkin LouisParkin merged commit 58bb723 into main Nov 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants