Stackstorm-nexus3 pack review request #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blag
suggested changes
Feb 22, 2019
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Looking very good so far. Only a few minor changes necessary, or maybe just comment why you implemented things a specific way.
Contributor
|
And I would like to see CI passing before promoting this. CI checks are currently failing: |
added 5 commits
February 23, 2019 20:04
blag
approved these changes
Feb 25, 2019
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Looking good - since the one unresolved issue is in the README I'm approving this.
Contributor
|
Everything is looking good, thank you for fixing the issues I pointed out. I'll be moving this to its own repository in a bit. |
Contributor
|
PR moved to its own repository: https://github.com/StackStorm-Exchange/stackstorm-nexus3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pack for sontatype Nexus Repository.
Kindly help me finish this pack by reviewing it.